Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Validation needed on Connect New Device IP Address/Hostname #419

Open
fifieldt opened this issue Feb 11, 2025 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@fifieldt
Copy link
Collaborator

Hardware

Other

Connection Type

HTTP

Local or Hosted

https://client.meshtastic.org

Firmware Version

2.6.0

Description

Steps to reproduce:

  1. Open https://client.meshtastic.org/
  2. New connection --> HTTP
  3. In the 'IP Address/Hostname' box, paste in a string with characters illegal for an IP or hostname, like "http://127.0.0.1:4403/"

What should happen:

  • Suitable error message should be displayed, connection is prevented

What happens instead

  • Connection attempt goes through, and then fails cryptically since it's not a valid hostname/IP

Relevant console output

@fifieldt fifieldt added the bug Something isn't working label Feb 11, 2025
@danditomaso
Copy link
Collaborator

100% agree on this, we need do some plumbing fixes inside the @meshtastic/js repo to support this, but overall this is something we need to add, as I am consistently annoyed when I dont get a connection but can still see the UI

@danditomaso danditomaso self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants