Lower logging level in process_incoming_bytes of stream_buffer #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lukipuki
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Can you please add motivation for this change? I'd really like to know if the received data has missing header bytes or other problems. I'd rarely turn on trace but error logging is always on.
If there's demand we could add a switch to downgrade the errors to trace! but I think most people need the information.
|
Then close #27 as it's not an issue, and we can choose to not merge this |
|
I'd still keep #27, if some data (debug logs) is expected to come from the client we should handle it better, but downgrading log level is not it. I'll look into it later. |
|
Sounds good. I have been using it as a library in another project which redirects those macros to system logs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with
tracebut could also bedebuginstead.Summary
Lower the logging levels to
traceinstead oferrorRelated Issues
Closes #27
Proposed Changes
traceper issue's suggestionChecklist