Add new channels from an add URL with the new --ch-add-url option

[mikeymakesit]

I added CLI option --ch-add-url with which one can provide an "add" URL to add new channel(s) to a node.

It won't make any changes to the primary channel or any existing secondary channels with the same name as a channel in the URL.

If the provided URL is not valid, it errors out with a relevant message.

[CLAassistant]

All committers have signed the CLA.

[ianmcorvidae]

Giving this a quick look -- I don't like that the format of the argument is different (--ch-add-url vs. --seturl isn't obviously a pair of similar commands), but I'm not sure what would be better. I don't like --addurl very much. Maybe we could change --seturl to --ch-set-url (with --seturl as an alias, for compatibility), and add the same metavar argument there too.

I'd also like it if passing a URL in either format works with either command. Maybe we could use https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlparse and then look at just the fragment, which is all we really need for this, if you're up for that change.

Thanks for the PR, in any case!

[mikeymakesit]

There's a trend with arguments for channel management being prefixed with --ch- so I followed that theme, whereas --seturl is treated in the code as a device configuration setting.

The channel sharing verbs in the iOS app are "replace" and "add" so maybe the CLI options should reflect that? For those reasons and based on your feedback, how about the following?

1. I keep --ch-add-url and update it to detect replace-style URLs and offer a suggestion to the user, doing nothing.
2. I create new option --ch-replace-url to do what --seturl does, but offering the suggestion to use the add-style option if an add-style URL was provided.
3. I make --seturl an alias for the new replace option.

@ianmcorvidae looking for feedback before adding commits.

[ianmcorvidae]

I think that's an acceptable place to start, so go for it. I don't like the usability of telling people to edit the URL if they want to change the way it works (particularly for changing a replace-style to an add-style, which is the more important direction to be able to change it) but I think it's good for the time being.

Sorry about my slow responses here, I've been slammed lately with real life. And thank you for putting in the work!

[ianmcorvidae]

Since I haven't heard back in a bit (probably since it took me so long to get back to you in the first place, sorry again about that) I took this over to get this across the finish line. Thanks for the contribution!

[codecov]

Codecov Report

Attention: Patch coverage is 17.94872% with 32 lines in your changes missing coverage. Please review.

Project coverage is 60.12%. Comparing base (03ac322) to head (84bec5a).
Report is 94 commits behind head on master.

Files with missing lines	Patch %	Lines
meshtastic/node.py	9.67%	28 Missing ⚠️
meshtastic/__main__.py	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   60.29%   60.12%   -0.18%     
==========================================
  Files          24       24              
  Lines        3816     4053     +237     
==========================================
+ Hits         2301     2437     +136     
- Misses       1515     1616     +101     

Flag	Coverage Δ
unittests	60.12% <17.94%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.