Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Name & MacOS Icon #482

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

matthewCmatt
Copy link
Contributor

@matthewCmatt matthewCmatt commented Feb 17, 2025

Resolves #429

Changes

  • Changes the Tauri productName from "meshtastic-network-management-client" to "Meshtastic Network Management Client"
  • Changes the MacOS icon to a new, rounded square icon.
Screenshot 2025-02-16 at 8 50 07 PM

Below is a short video summarizing these changes.

Screen.Recording.2025-02-16.at.8.06.44.PM.mov

The leftmost icon is the current NMC icon, mentioned in #429.
The center icon is the iOS Meshtastic app running on MacOS.
The rightmost icon is the new icon, with updated productName appearing on hover

Details

Is it differentiable from the iOS app?

I think the typical user won't install both apps, so this isn't a huge issue. If the user does have both, they can differentiate by the background color, or by opening the apps. Advanced users will figure it out however.

Does this update Windows/Linux icons?

No. I wasn't sure what shape would be good for these, so I left them as-is for now. Maybe just the same updated design, in a circle?

What is productName?

This is the name displayed to the user:

  • In the task bar/dock
  • In the Windows start menu/MacOS launch pad
  • In the process/task manager

It is not:

  • The title of the window, which remains the full app name:
Screenshot 2025-02-16 at 8 40 17 PM

How did you create the icon?

  1. Grab the Small White icon from the design repo https://github.com/meshtastic/design/blob/master/logo/svg/Mesh_Logo_White_Small.svg
  2. Drop it into an icon generator https://icon.kitchen/
  3. Add a margin of 13% and a gradient using the background colors from the NMC app

Note: The rest of the icons in src-tauri/icons were generated using the tauri icon CLI. This one was not. On subsequent icon updates, this should be noted.

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2025

CLA assistant check
All committers have signed the CLA.

@matthewCmatt matthewCmatt marked this pull request as ready for review February 17, 2025 01:59
@matthewCmatt matthewCmatt changed the title Update MacOS Icon Update Name & MacOS Icon Feb 17, 2025
@rcarteraz
Copy link
Member

I think the logo redesign is great! However, I don't think changing the product name to just "Meshtastic" is the correct way to go. While the number of people who would potentially have both apps installed is minimal, I do think it's important there is still some differentiation between the two.

The reason I say this is because of the name when you hover over the app, it would be best if that actually describes what the app is. I think if it's supported, I would say changing it from "meshtastic-network-management-client" to "Meshtastic Network Management Client" would be the best option, but if that's not supported then I would propose "MNMC" would be the next best thing.

@matthewCmatt
Copy link
Contributor Author

@rcarteraz Thanks for taking a look at this so quickly.

Changed the productName to match the current branding ("Meshtastic Network Management Client").

I'd love to have a discussion about shortening this name in general (maybe just dropping "Client"?), but that's a matter for another PR.

caveman99
caveman99 previously approved these changes Feb 18, 2025
@caveman99
Copy link
Member

Just something worth noting. I really like the white-on-black logo design introduced here and would also like to see that on the other platforms and in the client itself. The original logo design including the little plus sign to the upper left has since been re-used for meshtastic solutions. I think it fits there much better (meshtastic with added support, which the plus denotes).

@rcarteraz
Copy link
Member

Just something worth noting. I really like the white-on-black logo design introduced here and would also like to see that on the other platforms and in the client itself. The original logo design including the little plus sign to the upper left has since been re-used for meshtastic solutions. I think it fits there much better (meshtastic with added support, which the plus denotes).

That's a great point, we should really update all the logos being used. @matthewCmatt Would you be willing to undertake that and add to this PR?

  • Update other OSes to utilize new design (as you suggested you can keep the circle icon).
  • Update the logos being used within the app to the white logo without the +

@matthewCmatt
Copy link
Contributor Author

@rcarteraz Yeah, no problem.

Here's a quick draft of a Linux/Gnome-style logo. I tried to keep in line with the GNOME App Icon guidelines:

gnome

Thoughts on this vs a circular version?

@rcarteraz
Copy link
Member

@rcarteraz Yeah, no problem.

Here's a quick draft of a Linux/Gnome-style logo. I tried to keep in line with the GNOME App Icon guidelines:

gnome

Thoughts on this vs a circular version?

If it follows gnome app guidelines I say go for it!

rcarteraz
rcarteraz previously approved these changes Feb 19, 2025
@matthewCmatt
Copy link
Contributor Author

@rcarteraz This one's ready for review.

Added a circular logo for Windows/Linux, and switched out the logos in the app to remove the +

@rcarteraz rcarteraz merged commit aa927f6 into meshtastic:main Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Updated macOS icon
4 participants