Fix map symbols appearing on top of windows #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
previously approved these changes
Feb 19, 2025
|
@thebentern Merged in main to solve merge conflicts. Hopefully #486 doesn't cause another. p.s. left this message on the wrong PR, mb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #457
The base map currently has a z-index of 0.
Changes
This PR assigns the following new z-indexes for portions of the map:
Details
This is mostly done by wrapping the relevant elements in divs with
z-#Tailwind classes. The absolutely positioned windows were changed to usez-value: inheritto let theMapViewdictate this.The react-map-gl
Markerelements only take CSSProperties, and the DeckGL layer doesn't seem to be styleable from JSX, so those are styled differently accordingly.For Reviewers
Please let me know if I'm missing any elements, or if you think this may have strange interactions with anything. I don't have multiple nodes to test the app fully at the moment!