GPS.h cleanups round 3. #5447
Merged
GPS.h cleanups round 3. #5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
approved these changes
Nov 26, 2024
|
Looks like we don't have std:size: src/gps/GPS.cpp:446:47: error: 'size' is not a member of 'std' |
|
rats. ok, i'll fix it.
…On Mon, Nov 25, 2024 at 7:09 PM Tom Fifield ***@***.***> wrote:
Looks like we don't have std:size:
src/gps/GPS.cpp:446:47: error: 'size' is not a member of 'std'
if (++speedSelect == std::size(serialSpeeds)) {
—
Reply to this email directly, view it on GitHub
<#5447 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESTYS2GXP7IVAZVIP3YFYL2CPQ6LAVCNFSM6AAAAABSPL753KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZGU2TMOJZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
charlieh0tel
force-pushed
the
charlieh0tel/gps-cleanups-round-3
branch
from
342bd65
to
d2dd3d1
Compare
charlieh0tel
force-pushed
the
charlieh0tel/gps-cleanups-round-3
branch
from
d2dd3d1
to
921636b
Compare
|
still draft? |
|
@fifieldt should be good to go. |
fifieldt
force-pushed
the
charlieh0tel/gps-cleanups-round-3
branch
from
921636b
to
b2f177b
Compare
fifieldt
approved these changes
Nov 26, 2024
thebentern
approved these changes
Nov 27, 2024
|
argh, looks like trunk failed |
No effective behavior change. Protected members can be private so make it so. (Supporting subclasses needs a lot more work.) Moves uBloxGnssModelInfo into file scope. Moves uBloxProtocolVersion into uBloxGnssModelInfo. Moves baud rate arrays into file scope. Removes unused/ unimplemented powerStateToString. Signed-off-by: Christopher Hoover <[email protected]>
fifieldt
force-pushed
the
charlieh0tel/gps-cleanups-round-3
branch
from
822d285
to
d3a26b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last round of cleanups that are simple.