Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: ADC multiplier override missing from non-esp32 devices #698

Open
rcarteraz opened this issue Jun 16, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@rcarteraz
Copy link
Member

rcarteraz commented Jun 16, 2024

Firmware Version

All

What did you do?

Try to set ADC multiplier override but unable to because it’s only available on esp32 devices.

Expected Behavior

To be able to set the ADC multiplier override on non-esp32 boards such as nRF52 and pico.

Current Behavior

Setting is not available

Participation

  • [] I am willing to submit a pull request for this issue.

Additional comments

No response

@rcarteraz rcarteraz added the bug Something isn't working label Jun 16, 2024
@nolith
Copy link

nolith commented Jul 19, 2024

This is also missing for the heltec capsule sensor that is an esp32 device

@tekstrand
Copy link

Looked into this one a bit.

Issue seems to be here https://github.com/meshtastic/Meshtastic-Apple/blob/main/Meshtastic/Views/Settings/Config/PowerConfig.swift#L32

I think that either node, deviceConfig, or role is undefined which ends up preventing ADC config. I don't have the full emulator set up to be able to test this though.

@github-actions github-actions bot added the Stale Marked stale by the bot, will be closed automatically soon label Nov 8, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
@garthvh garthvh removed the Stale Marked stale by the bot, will be closed automatically soon label Nov 18, 2024
@garthvh garthvh reopened this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants