Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOps] Enhance MeshSync Discovery All Resources #274

Closed
theBeginner86 opened this issue Nov 23, 2023 · 11 comments
Closed

[DevOps] Enhance MeshSync Discovery All Resources #274

theBeginner86 opened this issue Nov 23, 2023 · 11 comments
Assignees
Labels
help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature

Comments

@theBeginner86
Copy link
Member

theBeginner86 commented Nov 23, 2023

Current Behavior

Currently MeshSync doesn't discover following K8s API Resources

  1. IngressClass
  2. NetworkPolicy
  3. ServiceAccount
  4. Roles
  5. ClusterRoleBindings
  6. RoleBindings
  7. ResourceQuotas
  8. PriorityClasses
  9. RuntimeClasses

Desired Behavior

Add support in MeshSync discovery pipeline to discovery all the available resources in Kubernetes cluster.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@theBeginner86 theBeginner86 added help wanted Extra attention is needed kind/enhancement Improvement in current feature labels Nov 23, 2023
@theBeginner86
Copy link
Member Author

@KiptoonKipkurui would you like to take this up?

@KiptoonKipkurui
Copy link
Member

@theBeginner86 Sure, I will take this up

@leecalcote
Copy link
Member

Gents, MeshSync should be able to be informed about ALL resources. Resources should not have to be named. Generally, resources should only be named as a blacklist of what not to be informed of (granted, MeshSync will support the flexibility of a whitelist, too, but that whitelist should be all resources by default). // @MUzairS15 @Aisuko

@KiptoonKipkurui
Copy link
Member

@theBeginner86 Following this discussion, this I believe this issue should change to enhance meshery to auto discover all resources in a cluster

Gents, MeshSync should be able to be informed about ALL resources. Resources should not have to be named. Generally, resources should only be named as a blacklist of what not to be informed of (granted, MeshSync will support the flexibility of a whitelist, too, but that whitelist should be all resources by default). // @MUzairS15 @Aisuko

@theBeginner86 theBeginner86 changed the title [DevOps] Enhance MeshSync Discovery [DevOps] Enhance MeshSync Discovery All Resources Dec 14, 2023
@theBeginner86
Copy link
Member Author

@theBeginner86 Following this discussion, this I believe this issue should change to enhance meshery to auto discover all resources in a cluster

Gents, MeshSync should be able to be informed about ALL resources. Resources should not have to be named. Generally, resources should only be named as a blacklist of what not to be informed of (granted, MeshSync will support the flexibility of a whitelist, too, but that whitelist should be all resources by default). // @MUzairS15 @Aisuko

Sounds good. Updated 👍

@Priyank-Vaidya
Copy link

@theBeginner86 I want to work on this issue

Copy link

stale bot commented Feb 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Feb 7, 2024
@leecalcote
Copy link
Member

@KiptoonKipkurui do we still have a hardcoded whitelist? Is it dynamically configurable, yet? If so, can you point me to the docs on it?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Feb 7, 2024
@KiptoonKipkurui
Copy link
Member

@KiptoonKipkurui do we still have a hardcoded whitelist? Is it dynamically configurable, yet? If so, can you point me to the docs on it?

The whitelist is currently hard coded in helm charts and meshsync, and only the items on this list would be discovered and watched. Currently each time you want to track events for a specific resource it has to be added to this both sections. Now the enhancement with this PR was to first use KubeAPI discovery API to get all resources in the cluster without being bound to the said list thus making all resources supported by default and second and enhancement to support using both fields blacklist and whitelist in our ConfigMap (current implementation has us using either one or the other).

Is Dynamically configurable: partial yes, for resources already here meshsync one can blacklist or whitelist and also control the observed events (added, modified, removed), but not for resources outside this list

Docs?: Docs exist to document the current behavior

Copy link

stale bot commented Mar 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 30, 2024
Copy link

stale bot commented Apr 13, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants