Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Persistent Volumes #215

Closed
leecalcote opened this issue Aug 16, 2023 · 4 comments
Closed

Support Persistent Volumes #215

leecalcote opened this issue Aug 16, 2023 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/enhancement Improvement in current feature kubernetes language/go Golang related

Comments

@leecalcote
Copy link
Member

leecalcote commented Aug 16, 2023 •
edited
Loading

Current Behavior
MeshSync doesn't discover this resource type.

Implementation
Add support for discovering this Kubernetes resource type. Do the same thing that was done here - 1b640b8, but for persistent volumes

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.
@leecalcote leecalcote added kind/enhancement Improvement in current feature issue/willfix This issue will be worked on good first issue Good for newcomers language/go Golang related help wanted Extra attention is needed kubernetes labels Aug 16, 2023
@VaibhavMalik4187
Copy link
Contributor

@leecalcote Can I give it a try?

@VaibhavMalik4187 VaibhavMalik4187 mentioned this issue Aug 17, 2023
Closed
@kituuu
Copy link

kituuu commented Aug 17, 2023

Can i try?

@theBeginner86
Copy link
Member

We already have support for Persistent Volumes. Was added in this PR #120

Screenshot 2023-08-17 at 8 28 43 PM

@leecalcote
Copy link
Member Author

Thank you, @theBeginner86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/enhancement Improvement in current feature kubernetes language/go Golang related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leecalcote @VaibhavMalik4187 @kituuu @theBeginner86