Updated SMI Parameters #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dhruv0000 <[email protected]>
1 task
leecalcote
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Looks good. A new image of learn-layer5:smi is available - https://hub.docker.com/r/layer5/learn-layer5/tags?page=1&ordering=last_updated
Signed-off-by: dhruv0000 <[email protected]>
kumarabd
reviewed
Jan 27, 2021
Signed-off-by: dhruv0000 <[email protected]>
1 task
|
Thanks for your contribution to the Layer5 community! 🎉
|
This was referenced Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dhruv0000 [email protected]
NOTE: This PR is effective after #70 is merged and
learn-layer5:smidocker image is updated. An update in go.mod would be required to point to the merged modules.Notes for Reviewers
ServiceMesh_Typeenum for using smi tool. Will link them here as I test/update them.mesehry-adaptor-library#33Signed commits