Bug/srivastavasujay/issue#677 #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srivastavasujay <[email protected]>
… interface Signed-off-by: srivastavasujay <[email protected]>
|
Thank you, @srivastavasujay! 👍 |
|
Thank you for this, @srivastavasujay 👏 |
|
@srivastavasujay, I wonder if you can assist in getting the two failing ❌ build checks (which are not necessarily related to your code changes) rectified and our builds here passing. ✅ What do you say? 😁 |
|
Here's are the issues you can try @srivastavasujay (regarding what @leecalcote mentioned above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #677
broker/nats/nats.go
Removed deprecated nats.EncodedConn and related methods:
Replaced nats.EncodedConn with nats.Conn.
Removed nats.NewEncodedConn and handled message encoding manually using encoding/json.
Updated methods to use nats.Conn for publishing and subscribing messages.Fix Subscribe method signature in Nats struct to match broker.Handler interface
models/meshmodel/core/policies/rego_policy_relationship.go:
Updated OPA packages to use v1 versions:
models/oci/oci.go
Replaced deprecated oras.PackManifestVersion1_1_RC4
Notes for Reviewers
Signed commits