Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Codecov build checks #642

Open
leecalcote opened this issue Jan 14, 2025 · 3 comments
Open

Failing Codecov build checks #642

leecalcote opened this issue Jan 14, 2025 · 3 comments
Labels
area/tests Testing / quality assurance help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related

Comments

@leecalcote
Copy link
Member

leecalcote commented Jan 14, 2025

Current Behavior

See the failing codecov checks here as an example of the issue - https://github.com/meshery/meshkit/actions/runs/12773435627/job/35612627610

Expected Behavior
All Codecov checks should be passing or should be removed if they are no longer relevant.


Contributor Guides and Handbook

@leecalcote leecalcote added area/tests Testing / quality assurance help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related labels Jan 14, 2025
@MAX-786
Copy link

MAX-786 commented Feb 23, 2025

Hey @leecalcote , I think from what i could get from a quick glimpse is that here this might be failing because Bitnami has moved to using OCI registries instead of plain HTTPS URLs for their charts like here
I think this need to be looked deep into.
I'm still exploring meshery codebase so apologies for any mis information :)
THanks!

@MAX-786
Copy link

MAX-786 commented Feb 23, 2025

the other issue is this, and i think this is the file i suppose and after reading the error logs we can simply conclude that it expects ../core.json to be there but i don't see one.
Again i am not meshkit codebase expert but this is just from a glimpse . Please feel free to correct me :)
Thanks!

@MAX-786
Copy link

MAX-786 commented Feb 23, 2025

and lastly this logical error , it's a bit confusing because For the catalog_data case, ShouldPass (L79) is set to false, but the test error message indicates it got true when it wanted true , same goes for models case.
Hope this might help pin pointing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Testing / quality assurance help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related
Projects
None yet
Development

No branches or pull requests

2 participants