Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from MeshModel to Model #467

Closed
gyohuangxin opened this issue Feb 28, 2024 · 5 comments · May be fixed by #468
Closed

Move from MeshModel to Model #467

gyohuangxin opened this issue Feb 28, 2024 · 5 comments · May be fixed by #468
Assignees
@gyohuangxin
Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature

Comments

@gyohuangxin
Copy link
Member

Desired Behavior

As mentioned in slack message, we should move MeshModel to Model in meshkit repo, related to meshery/meshery-adapter-library#153

I found that meshkit, which meshery-adapter-library is importing as a dependence, is also using MeshModel as the package name: https://github.com/meshery/meshkit/tree/master/models/meshmodel
We also need to change them to Model right? If yes, I can work on that first and create a new meshkit release.
@gyohuangxin gyohuangxin added the kind/enhancement Improvement in current feature label Feb 28, 2024
@welcome Welcome
Copy link

welcome bot commented Feb 28, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@gyohuangxin gyohuangxin self-assigned this Feb 28, 2024
@gyohuangxin gyohuangxin mentioned this issue Feb 28, 2024
Open
1 task
@stale Stale
Copy link

stale bot commented Apr 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 14, 2024
@stale Stale
Copy link

stale bot commented May 2, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed May 2, 2024
@gyohuangxin gyohuangxin reopened this May 5, 2024
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label May 5, 2024
@stale Stale
Copy link

stale bot commented Jun 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 19, 2024
@stale Stale
Copy link

stale bot commented Jul 3, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyohuangxin gyohuangxin

Labels
issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move MeshModel to Model. gyohuangxin/meshkit
1 participant
@gyohuangxin