Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MeshSpec Params #71

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Updated MeshSpec Params #71

merged 2 commits into from
Feb 3, 2021

Conversation

dhruv0000
Copy link
Member

Signed-off-by: dhruv0000 [email protected]
Description
This PR fixes of changes in #31 and #33

Notes for Reviewers

  • Added "type" in MeshSpec
  • Updated go.mod to point to master branch of meshkit and meshery-adaptor-library
  • go.mod points to smp V0.3.3

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@dhruv0000 dhruv0000 changed the title Smi update Updated MeshSpec Params Feb 2, 2021
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. ✔️

@leecalcote leecalcote merged commit dd7be53 into meshery:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants