-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Consistent Use of MeshKit Errors in meshery-nginx-sm #288
Comments
Hi @singh1203 I'm a beginner and I want to give a try to solving this issue what are prerequisites for solving this issue?? I'm familiar with Error handling in Golang any other things should I learn it would be helpful for me to solve the issue |
Hi @singh1203, can I take this one |
Thanks for your inquiry, @Sylani-55. Please make sure to run the repository locally and review the mentioned documentation. |
Thanks for hopping in @ShivanshuGupta07, but we follow FCFS. Maybe you can review the PR or find similar ones missing in other repositories as well. |
No Problem @singh1203, I will definitely try to find some other "good first issue" |
@Sylani-55 Just following up, please provide an update on the progress. |
Hi Sourabh Singh, Thank you for checking in. I apologize for the delay in resolving the issue. I've been working on it and have made some progress, but I'm not quite finished yet. I plan to dedicate more time over the next few days and aim to have it completed by this Sunday. I appreciate your understanding and will keep you posted if anything changes. Please let me know if there's anything else you'd like me to focus on. Best regards, |
@Sylani-55, checking in... it'd be good to get an update on this from you. |
Hello @Sylani-55 @leecalcote is there any update in this ticket I desire to provide assistance or take over the ticket if necessary. |
Not having heard from, @Sylani-55, yes, thank you for raising your hand, @aarochuk. |
Current Behavior
Currently, there are instances where errors are being used directly instead of MeshKit errors, which impacts the consistency and quality of error reporting across the project.
Desired Behavior
References
Meshery Documentation on Meshkit
Make sure to follow these guidelines during writing Meshkit errors
https://discuss.layer5.io/t/best-practices-for-writing-meshkit-errors/5536
Also here is an example PR to which you can refer:
#11340
Contributor Guides and Resources
The text was updated successfully, but these errors were encountered: