generated from meshery/meshery
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script enhancement #51
Merged
leecalcote
merged 24 commits into
meshery:master
from
Aijeyomah:install-script-enhancement
Nov 5, 2024
Merged
Install script enhancement #51
leecalcote
merged 24 commits into
meshery:master
from
Aijeyomah:install-script-enhancement
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aijeyomah
force-pushed
the
install-script-enhancement
branch
from
November 3, 2024 00:29
f687479
to
b782104
Compare
- Update Makefile to deploy plugin with binary, plugin.yaml, and install-binary.sh - Refine goreleaser configuration for correct YAML structure and build setup - Ensure install-binary.sh script handles plugin installation effectively Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Aijeyomah
force-pushed
the
install-script-enhancement
branch
from
November 3, 2024 02:07
710f9a3
to
e8e3aba
Compare
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
leecalcote
reviewed
Nov 5, 2024
Signed-off-by: Lee Calcote <[email protected]>
leecalcote
reviewed
Nov 5, 2024
"name": "helm-kanvas-snapshot", | ||
"type": "component", | ||
"next_error_code": 1000 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have more error codes than this? Those will come in a subsequent PR, perhaps?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits