Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script enhancement #51

Merged
merged 24 commits into from
Nov 5, 2024

Conversation

Aijeyomah
Copy link
Contributor

@Aijeyomah Aijeyomah commented Nov 3, 2024

Notes for Reviewers

This PR fixes #

  • Add an install binary script to install helm kanvas snapshot plugin
  • Update Goreleaser
  • Fix error code builds

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Nov 3, 2024
- Update Makefile to deploy plugin with binary, plugin.yaml, and install-binary.sh
- Refine goreleaser configuration for correct YAML structure and build setup
- Ensure install-binary.sh script handles plugin installation effectively

Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
Signed-off-by: Eti Ijeoma <[email protected]>
install-binary.sh Outdated Show resolved Hide resolved
"name": "helm-kanvas-snapshot",
"type": "component",
"next_error_code": 1000
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have more error codes than this? Those will come in a subsequent PR, perhaps?

@leecalcote leecalcote merged commit d66693a into meshery:master Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants