Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency svelte to v4.2.19 [security] - autoclosed #1523

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 30, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
svelte (source) 4.2.18 -> 4.2.19 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45047

Summary

A potential XSS vulnerability exists in Svelte for versions prior to 4.2.19.

Details

Svelte improperly escapes HTML on server-side rendering. It converts strings according to the following rules:

  • If the string is an attribute value:
    • " -> "
    • & -> &
    • Other characters -> No conversion
  • Otherwise:
    • < -> &lt;
    • & -> &amp;
    • Other characters -> No conversion

The assumption is that attributes will always stay as such, but in some situation the final DOM tree rendered on browsers is different from what Svelte expects on server-side rendering. This may be leveraged to perform XSS attacks. More specifically, this can occur when injecting malicious content into an attribute within a <noscript> tag.

PoC

A vulnerable page (+page.svelte):

<script>
import { page } from "$app/stores"

// user input
let href = $page.url.searchParams.get("href") ?? "https://example.com";
</script>

<noscript>
  <a href={href}>test</a>
</noscript>

If a user accesses the following URL,

http://localhost:4173/?href=</noscript><script>alert(123)</script>

then, alert(123) will be executed.

Impact

XSS, when using an attribute within a noscript tag


Release Notes

sveltejs/svelte (svelte)

v4.2.19

Compare Source

Patch Changes
  • fix: ensure typings for <svelte:options> are picked up (#​12902)

  • fix: escape < in attribute strings (#​12989)


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit dce90e2
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/672e3351467e080008e7ad3e
😎 Deploy Preview https://deploy-preview-1523--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 30, 2024

Mermaid Live Editor    Run #1643

Run Properties:  status check failed Failed #1643  •  git commit 8d4c037a77 ℹ️: Merge dce90e2ff16ef40ae4a85eda1ae7915787ab4d5a into ee156c7e690ebdadd65af3aba2cd...
Project Mermaid Live Editor
Branch Review renovate/npm-svelte-vulnerability
Run status status check failed Failed #1643
Run duration 02m 14s
Commit git commit 8d4c037a77 ℹ️: Merge dce90e2ff16ef40ae4a85eda1ae7915787ab4d5a into ee156c7e690ebdadd65af3aba2cd...
Committer renovate[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 6
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 28
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/history.spec.ts • 1 failed test

View Output Video

Test Artifacts
Save History > should be able to restore and delete Screenshots Video

@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch from 2975df6 to 23003d0 Compare September 5, 2024 04:28
@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch 3 times, most recently from b8cd974 to 6dceadf Compare September 16, 2024 16:45
@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch 3 times, most recently from 3b448e2 to 0870a6a Compare October 4, 2024 17:25
@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch from 0870a6a to e067663 Compare October 29, 2024 19:04
@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch 3 times, most recently from 7290565 to d5844fd Compare November 8, 2024 15:49
@renovate renovate bot force-pushed the renovate/npm-svelte-vulnerability branch from d5844fd to dce90e2 Compare November 8, 2024 15:50
@renovate renovate bot changed the title chore(deps): update dependency svelte to v4.2.19 [security] chore(deps): update dependency svelte to v4.2.19 [security] - autoclosed Nov 8, 2024
@renovate renovate bot closed this Nov 8, 2024
@renovate renovate bot deleted the renovate/npm-svelte-vulnerability branch November 8, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants