Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge only if clean by default #768

Open
Alexander-Shukaev opened this issue Jul 12, 2024 · 0 comments
Open

Merge only if clean by default #768

Alexander-Shukaev opened this issue Jul 12, 2024 · 0 comments

Comments

@Alexander-Shukaev
Copy link

Alexander-Shukaev commented Jul 12, 2024

if (pullRequest.data.mergeable_state !== 'blocked' && pullRequest.data.state === 'open') {

should rather check mergeable for true and mergeable_state for "clean" (all checks passed, not just required ones as per not "blocked") to get behavior similar to GH automerge and what one would typically expect as do the right thing/least harm...

I would also suggest a new option to instead of direct merging, just automatically enable GH automerge (Renovate bot does the same thing).

See #395 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant