Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router as an object #35

Open
alexis-barge opened this issue Oct 30, 2024 · 0 comments
Open

Router as an object #35

alexis-barge opened this issue Oct 30, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@alexis-barge
Copy link
Collaborator

Router is currently a function exported inside Loop.
Router could be an object that takes inputs variables names, output variables names, and a Model (function) that links them. This way, it is possible to check inside Eophis if returned outputs should be None or Model results.

The idea is to get rid of Model architecture that requires to send back None if at least one None in the inputs.

This requires to find a way to easily transfer several Routers to Loop.

This modifies the API and implies documentation updates.

@alexis-barge alexis-barge added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 30, 2024
@alexis-barge alexis-barge added this to the Release_v2.0.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant