Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

256 Character limit for input arguments #13

Open
willirath opened this issue Feb 15, 2017 · 3 comments
Open

256 Character limit for input arguments #13

willirath opened this issue Feb 15, 2017 · 3 comments

Comments

@willirath
Copy link
Contributor

Currently, there are many 256-character limits. It would be nice to expand this to allow for (much) more than this.

An example: I have section_*.dat-files I use with cdf_xtrac_brokenline to extract data along all of the WOCE sections. Naming the section files section_WOCEA1.dat,section_WOCEA2.dat,... etc. I get a cldum about 1300 characters.

The limit used to be 80 characters and has already been expanded to 256 characters in: 6652eb4

How far could we go with this? Would it be problematic to allow for LEN=2048 or even more?

@willirath willirath changed the title 255 Character limit for input arguments 256 Character limit for input arguments Feb 15, 2017
@molines
Copy link
Member

molines commented Feb 15, 2017

I have no particular concern about raising the limit to 2048 characters. I have not tried already if fortran support this, but I guess yes.

But there also might be an issue with the linux maximum length for a command line, I am pretty sure that is well above, however.

The nicer solution will be to allow for 1 file with all sections inside the file ( just a concatenation of separate section files). Just need to write the parser for this kind of file. Should not be too complicated as the number of points defining the section is already coded into the bloc for a section... Nice exersize, I will think about it !

@willirath
Copy link
Contributor Author

I have no particular concern about raising the limit to 2048 characters. I have not tried already if fortran support this, but I guess yes.

But there also might be an issue with the linux maximum length for a command line, I am pretty sure that is well above, however.

I'll try it on our machines and let you know.

The nicer solution will be to allow for 1 file with all sections inside the file ( just a concatenation of separate section files). Just need to write the parser for this kind of file. Should not be too complicated as the number of points defining the section is already coded into the bloc for a section... Nice exersize, I will think about it !

Before you do this: The current version has some nice effects, too. I like being able to do

cdf_xtrac_brokenline ... -f `ls -1 section_*.dat | paste -sd,`

and adding sections by just committing a new file to the list of available sections.

@molines
Copy link
Member

molines commented Feb 15, 2017

Yes I agree, in any case, if I code the possibility for a single file ( multi section) I will keep also the original possibility (multi files) ..[ and the question of cldum remains the same :)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants