Creating directories is not working properly

[fischerling]

Since my attempts (f7e53f9 and 4d45044) to fix creation and appending to files, the creation of directories is not working anymore.

This can be easily verified using the new t_mkdir test introduced in #78 or by running the following commands in MentOS

$ mkdir outer
$ mkdir outer/inner
$ ls outer

Additionally, running fsck.ext2 -fn rootfs.img lists a bunch of errors.

I included the output of fsck.ext2 after running all the tests using the qemu-test target.

e2fsck 1.47.1 (20-May-2024)
Pass 1: Checking inodes, blocks, and sizes
Inode 680, i_size is 16384, should be 8192.  Fix? no

Inode 680, i_blocks is 16, should be 8.  Fix? no

Inode 681, i_size is 12288, should be 8192.  Fix? no

Inode 681, i_blocks is 16, should be 8.  Fix? no

Pass 2: Checking directory structure
Directory inode 680 has an unallocated block #0.  Allocate? no

Directory inode 681 has an unallocated block #0.  Allocate? no

Entry '..' in .../outer (681) is duplicate '..' entry.
Fix? no

Entry '..' in .../outer (681) is duplicate '..' entry.
Fix? no

Entry '..' in .../outer (681) is a link to directory /t_mkdir (680).
Clear? no

Pass 3: Checking directory connectivity
'..' in /t_mkdir (680) is <The NULL inode> (0), should be / (2).
Fix? no

'..' in .../outer (681) is <The NULL inode> (0), should be ... (680).
Fix? no

Pass 4: Checking reference counts
Inode 2 ref count is 11, should be 10.  Fix? no

Inode 680 ref count is 3, should be 2.  Fix? no

Inode 681 ref count is 2, should be 1.  Fix? no

Unattached inode 682
Connect to /lost+found? no

Pass 5: Checking group summary information
Block bitmap differences:  -(3960--3961) -3963 +3968
Fix? no

Inode bitmap differences:  +682
Fix? no


rootfs: ********** WARNING: Filesystem still has errors **********

rootfs: 681/8192 files (0.3% non-contiguous), 3968/8192 blocks

[Galfurian]

Sorry for my late reply. I'll look into this problem right away.

Thank you for opening this issue!

[fischerling]

Sorry for my late reply. I'll look into this problem right away.

Thank you for opening this issue!

No worries! Thanks for investigating and fixing it :)