Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assembly for x86-64 #2

Closed
randomPoison opened this issue Feb 22, 2023 · 0 comments
Closed

Enable assembly for x86-64 #2

randomPoison opened this issue Feb 22, 2023 · 0 comments
Assignees

Comments

@randomPoison
Copy link
Collaborator

The original c2rust transpile of dav1d disabled assembly support in the meson configuration options (-Denable_asm=false). To start getting assembly integrated into the Rust port we should start by getting x86_64 assembly enabled, built, and linked.

To re-transpile with assembly enabled, follow the steps in this comment but in the meson configure step, change enable_asm=false to enable_asm=true.

The build.rs will need to be setup to compile the appropriate source files using NASM and link the build output. Check out the build.rs in the rav1e project for an example of how a similar project is doing this using the nasm-rs crate.

@randomPoison randomPoison self-assigned this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants