fix: logmessage for body access over stream in OpenTelemetry (#1977)

* fix: logmessage for body access over stream in OpenTelemetry

* refactor: minor

* fix: catch network exceptions in getBodyAsStreamDecoded

---------

Co-authored-by: Tobias Polley <[email protected]>

Author: predic8

core/src/main/java/com/predic8/membrane/core/interceptor/opentelemetry/OpenTelemetryInterceptor.java

@@ -28,6 +28,7 @@
 import static com.predic8.membrane.core.interceptor.Outcome.*;
 import static com.predic8.membrane.core.interceptor.opentelemetry.HTTPTraceContextUtil.*;
 import static com.predic8.membrane.core.openapi.serviceproxy.OpenAPIInterceptor.*;
+import static com.predic8.membrane.core.util.ExceptionUtil.*;
 import static io.opentelemetry.api.common.AttributeKey.*;
 import static io.opentelemetry.api.common.Attributes.*;
 import static io.opentelemetry.api.trace.SpanKind.*;
@@ -75,10 +76,16 @@ public Outcome handleRequest(Exchange exc) {
         var span = getExchangeSpan(exc);
         setSpanHttpHeaderAttributes(exc.getRequest().getHeader(), span);
 
-        if (logBody) {
+        if (!logBody)
+            return CONTINUE;
+
+        // try is needed to catch network errors in getBodyAsStringDecoded()
+        try {
             span.addEvent("Request", of(
                     stringKey("Request Body"), exc.getRequest().getBodyAsStringDecoded()
             ));
+        } catch (Exception e) {
+            log.debug("Can't log request body having problems to read stream. {}", concatMessageAndCauseMessages(e));
         }
 
         return CONTINUE;
@@ -95,9 +102,15 @@ public Outcome handleResponse(Exchange exc) {
         }
 
         if (logBody) {
-            span.addEvent("Response", of(
-                    stringKey("Response Body"), exc.getResponse().getBodyAsStringDecoded()
-            ));
+            // try is needed to catch network errors in getBodyAsStringDecoded()
+            try {
+                span.addEvent("Response", of(
+                        stringKey("Response Body"),
+                        exc.getResponse().getBodyAsStringDecoded()
+                ));
+            } catch (Exception e) {
+                log.debug("Can't log response body having problems to read stream. {}", concatMessageAndCauseMessages(e));
+            }
         }
 
         span.addEvent("Close Exchange").end();