Skip to content

bug: is_sorted should be true for SQLStream with replication keys #1950

@pnadolny13

Description

@pnadolny13

Not sure if this is a bug or a design decision but shouldn't is_sorted be set to true in the default SQLStream implementation if we're adding an order by clause

query = query.order_by(replication_key_col)
?

Currently it accepts the default of False.

@edgarrmondragon what do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions