Skip to content

Commit

Permalink
Confirm that we're not making any breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Nov 30, 2024
1 parent 42a702d commit 4301625
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/core/test_connector_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ def test_unknown_format(self, json_schema_to_sql: JSONSchemaToSQL):
assert isinstance(result, sa.types.VARCHAR)

def test_custom_fallback(self):
json_schema_to_sql = JSONSchemaToSQL(max_varchar_length=None)
json_schema_to_sql = JSONSchemaToSQL()
json_schema_to_sql.fallback_type = sa.types.CHAR
jsonschema_type = {"cannot": "compute"}
result = json_schema_to_sql.to_sql_type(jsonschema_type)
Expand All @@ -668,7 +668,7 @@ def handle_raw_string(self, schema):

return super().handle_raw_string(schema)

json_schema_to_sql = CustomJSONSchemaToSQL(max_varchar_length=None)
json_schema_to_sql = CustomJSONSchemaToSQL()

vanilla = {"type": ["string"]}
result = json_schema_to_sql.to_sql_type(vanilla)
Expand Down

0 comments on commit 4301625

Please sign in to comment.