Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes on android 12 devices due to useNativeDriver true on slide animations #1011

Open
5 tasks done
vibhor-d11 opened this issue Mar 13, 2024 · 1 comment
Open
5 tasks done

Comments

@vibhor-d11
Copy link

vibhor-d11 commented Mar 13, 2024

Is this a bug report, a feature request, or a question?

Bug Report

Have you followed the required steps before opening a bug report?

(Check the step you've followed - put an x character between the square brackets ([]).)

Have you made sure that it wasn't a React Native bug?

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?

It is specific to android, however it is not easily reproducible but we have instances of this crash on our firebase for our users.

Is the bug reproductible in a production environment (not a debug one)?

Not reproducible but occuring for large userbase.

Environment

Android (12.0)

Expected Behavior

Should run fine with given default configurations

Actual Behavior

Currently their is no provision to enable/disable useNativeDriver for react native snap carousal. For carousal animations useNativeDriver is set to true i.e they run on UI thread by default. We encountered some crashes related to Animated node that occurred only on Android 12 devices and after digging into it we get to know it is related to useNativeDriver set to true for carousal animations. Also their is an open issue in react-native related to this crash: Link. So we added a patch in react-native-snap-carousal library for disabling useNativeDriver for devices having Android 12 and that reduces the crash rate for that crash with very few instances now. We have been using this for almost a year and haven't faced any issue with our app exposed to more than 20 million users. So we though of adding support for enable/disable useNativeDriver for react-native-snap-carousal as a exposed prop.

Reproducible Demo

Not reproducible but occuring for large userbase having instances on firebase.

Steps to Reproduce

Their is no defined steps to reproduce this issue but we instances of this crash in our firebase for large numbers of users and it was reduced by setting useNativeDriver to false. Here is the stacktrace for it.

image

@yasir6jan
Copy link

yasir6jan commented Jul 15, 2024

Hi @IsaiaPhiliph
When will there be a new version release for https://github.com/IsaiaPhiliph/react-native-snap-carousel-v4?
We wanted to make use of the changes merged mentioned in this issue.
Reference Github PR - IsaiaPhiliph#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants