-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Json
and Ppx_deriving_runtime
#36
Comments
Thanks for opening the issue, @jchavarri. So yeah, I propose to make a single lib which is usable both by user-written code and function as a runtime lib for ppx. There's already a big overlap between the Another advantage is that At the same time, I agree with @jchavarri that the chosen |
I think this also addresses #9 |
I think JSON is nice ^^ |
Idea by @andreypopp (pls explain more deets if you think I'm missing): Unify
Json
andPpx_deriving_runtime
modules.Upside: Shorter name, easier to find.
Downside: might lead to larger JavaScript bundles for people not using the PPX.
To mitigate the downside, maybe we could create a new
Melange_json
module thatinclude
s both? I have always thought that the top levelJson
module is a bit presumptuous.cc @anmonteiro
The text was updated successfully, but these errors were encountered: