Don't send body if empty

Author: sanders41

meilisearch/_httprequests.py

@@ -33,7 +33,13 @@ def send_request(
             self.headers["Content-Type"] = content_type
         try:
             request_path = self.config.url + "/" + path
-            if isinstance(body, bytes):
+            if body is None or body == "":
+                request = http_method(
+                    request_path,
+                    timeout=self.config.timeout,
+                    headers=self.headers,
+                )
+            elif isinstance(body, bytes):
                 request = http_method(
                     request_path,
                     timeout=self.config.timeout,
@@ -45,7 +51,7 @@ def send_request(
                     request_path,
                     timeout=self.config.timeout,
                     headers=self.headers,
-                    data=json.dumps(body) if body else "" if body == "" else "null",
+                    data=json.dumps(body),
                 )
             return self.__validate(request)
 

tests/settings/test_settings_displayed_attributes_meilisearch.py

@@ -36,8 +36,7 @@ def test_update_displayed_attributes_to_none(empty_index):
     get_attributes = index.get_displayed_attributes()
     for attribute in DISPLAYED_ATTRIBUTES:
         assert attribute in get_attributes
-    # Launch test to update at null the setting
-    response = index.update_displayed_attributes(None)
+    response = index.reset_displayed_attributes()
     index.wait_for_task(response.task_uid)
     response = index.get_displayed_attributes()
     assert response == ["*"]

tests/settings/test_settings_distinct_attribute_meilisearch.py

@@ -28,7 +28,7 @@ def test_update_distinct_at_to_none(empty_index):
     response = index.get_distinct_attribute()
     assert response == NEW_DISTINCT_ATTRIBUTE
     # Launch test to update at null the setting
-    response = index.update_distinct_attribute(None)
+    response = index.reset_distinct_attribute()
     index.wait_for_task(response.task_uid)
     response = index.get_distinct_attribute()
     assert response == DEFAULT_DISTINCT_ATTRIBUTE

tests/settings/test_settings_filterable_attributes_meilisearch.py

@@ -32,7 +32,7 @@ def test_update_filterable_attributes_to_none(empty_index):
     for attribute in FILTERABLE_ATTRIBUTES:
         assert attribute in get_attributes
     # Launch test to update at null the setting
-    response = index.update_filterable_attributes(None)
+    response = index.reset_filterable_attributes()
     index.wait_for_task(response.task_uid)
     response = index.get_filterable_attributes()
     assert response == []

tests/settings/test_settings_ranking_rules_meilisearch.py

@@ -31,7 +31,7 @@ def test_update_ranking_rules_none(empty_index):
     for rule in NEW_RANKING_RULES:
         assert rule in response
     # Launch test to update at null the setting
-    response = index.update_ranking_rules(None)
+    response = index.reset_ranking_rules()
     index.wait_for_task(response.task_uid)
     response = index.get_ranking_rules()
     for rule in DEFAULT_RANKING_RULES:

tests/settings/test_settings_searchable_attributes_meilisearch.py

@@ -37,7 +37,7 @@ def test_update_searchable_attributes_to_none(empty_index):
     for attribute in NEW_SEARCHABLE_ATTRIBUTES:
         assert attribute in response
     # Launch test to update at null the setting
-    response = index.update_searchable_attributes(None)
+    response = index.reset_searchable_attributes()
     index.wait_for_task(response.task_uid)
     response = index.get_searchable_attributes()
     assert response == ["*"]

tests/settings/test_settings_sortable_attributes_meilisearch.py

@@ -32,7 +32,7 @@ def test_update_sortable_attributes_to_none(empty_index):
     for attribute in SORTABLE_ATTRIBUTES:
         assert attribute in get_attributes
     # Launch test to update at null the setting
-    response = index.update_sortable_attributes(None)
+    response = index.reset_sortable_attributes()
     index.wait_for_task(response.task_uid)
     response = index.get_sortable_attributes()
     assert response == []