Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption for data at storage #68

Open
1Euro7Cent opened this issue Nov 29, 2023 · 3 comments
Open

Add encryption for data at storage #68

1Euro7Cent opened this issue Nov 29, 2023 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@1Euro7Cent
Copy link

See details/reasons here immich-app/immich#450 this is a relative important feature for me. But I need to figure it out by the "hard way"

@meichthys meichthys added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 29, 2023
@ildyria
Copy link
Contributor

ildyria commented Dec 25, 2023

I don't think that is something a photo gallery should concern about:

https://stackoverflow.com/a/3938083

You cannot, however, remove the need for the user to trust the server because the server can send whatever JavaScript code it wants to to the client, which can send a copy of the image to anyone when it is decrypted.

The explanations of immich-app/immich#450 also makes quite good sense.

@BlackLotus
Copy link

BlackLotus commented May 29, 2024

Since Android Client, Desktop Client and so on are options in this repo this should be added. (not javascript code that can be modified by a rogue admin)
If the encryption is handled clientside and is implemented well it can be done.
Ente #76 for instance encrypts everything by default (using PGP). It supports everything mentioned here

There is no way to implement "e2ee" in a solution like immich. If you want e2ee in a media storage, put your photos in an encrypted zip file and put it on an SFTP server. You can't have galleries, browsing, metadata with e2ee

and the comment is only true, because immich was build not with privacy in mind (which is ok), but there certainly are solutions that offer all that and more and feature e2ee.

Nextcloud and Ente were designed with privacy first in mind and so support encryption by default.

Edit: ente has it's implementation split into data server (museum) and clients (web, android, desktop, ...) so you could host the web frontend yourself as well without having to trust the admin.
I'm not affiliated with ente, I just host it myself

@ChocolateLoverRaj
Copy link

@ildyria in this situation encryption does matter:

  • You get the official app for the photos solution, such as Ente or Immich. You trust that app with your unencrypted / decrypted images.
  • You don't want the photos to be stored on the server unencrypted. You want your photos to be private even if:
    • The admin is nosy
    • Someone gains access to the server
    • Someone gets the hard drive and the file system is not encrypted

Personally I would trust official apps of big projects such as Ente and Immich more than the server administrators. Even if I am the server administrator, having encrypted photos (such as what Ente does) would give me a peace of mind so even if someone got access to the physical drives or ssh access to my server, they wouldn't be able to see my photos unless they got access to the keys on my phone.

My explanation is like an elaboration of @BlackLotus 's explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants