Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loss Concealment #12

Open
kelchy opened this issue Feb 26, 2015 · 2 comments
Open

Loss Concealment #12

kelchy opened this issue Feb 26, 2015 · 2 comments

Comments

@kelchy
Copy link

kelchy commented Feb 26, 2015

Hi,

I noticed that this patch does not compensate for lost packets. May I know the reason why?
according to opus API, you should use opus_decode with null pointer when lost packets are detected.
Is this something not needed? will quality be improved if we do this?
@lminiero
Copy link
Member

lminiero commented May 6, 2015

Not sure we can figure out lost packets from within a codec plugin: all methods are invoked by the Asterisk core, and so we wouldn't be able to understand if and when a packet is lost.

@Dimitripietro
Copy link

Hi,

From what I understand, one of the major feature of Opus is PLC. Using this patch Asterisk/opus is not compensating for lost packet at all ? That mean a conversation with 1% packets loss using Opus will have the same quality than the same 1% packets loss with G711 for example ?

traud added a commit to traud/asterisk-opus that referenced this issue Dec 7, 2015
@traud
added PLC and FEC, resolves seanbright#9 and resolves meetecho#12
8700cb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lminiero @kelchy @Dimitripietro