Skip to content

Commit aca8bab

Browse files
dianabarsangarethbowen
authored andcommitted
Don't clear state if you're gonna show a popup
#5445
1 parent 0ed2424 commit aca8bab

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

tests/e2e/reports-subject.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ describe('Reports Summary', () => {
250250
return browser
251251
.wait(() => element(
252252
by.cssContainingText('#reports-content .item-summary .sender .phone', CAROL.phone)).isPresent(),
253-
10000
253+
20000
254254
)
255255
.catch(loadReport);
256256
};
@@ -260,7 +260,7 @@ describe('Reports Summary', () => {
260260
const getElementText = (css, attempt) => {
261261
attempt = attempt || 0;
262262

263-
return helper.getTextFromElement(element(by.css(css)))
263+
return helper.getTextFromElement(element(by.css(css)))
264264
.then((text) => {
265265
return text;
266266
}, (err) => {

webapp/src/js/controllers/inbox.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,17 +199,18 @@ const LAST_REPLICATED_SEQ_KEY = require('../bootstrapper/purger').LAST_REPLICATE
199199
});
200200

201201
$rootScope.$on('$stateChangeStart', function (event, toState, toParams, fromState){
202-
if (toState.name.indexOf('reports') === -1 || toState.name.indexOf('contacts') === -1 || toState.name.indexOf('tasks') === -1 || toState.name.indexOf('messages.detail') === -1) {
203-
$scope.unsetSelected();
204-
}
205-
if (toState.name.indexOf('tasks.detail') === -1) {
206-
Enketo.unload($scope.form);
207-
$scope.unsetSelected();
208-
}
209-
if (toState.name.split('.')[0] !== fromState.name.split('.')[0]){
210-
$scope.$broadcast('ClearSelected');
211-
}
212202
if (!$scope.enketoStatus.edited){
203+
if (toState.name.indexOf('reports') === -1 || toState.name.indexOf('contacts') === -1 || toState.name.indexOf('tasks') === -1 || toState.name.indexOf('messages.detail') === -1) {
204+
$scope.unsetSelected();
205+
}
206+
if (toState.name.indexOf('tasks.detail') === -1) {
207+
Enketo.unload($scope.form);
208+
$scope.unsetSelected();
209+
}
210+
if (toState.name.split('.')[0] !== fromState.name.split('.')[0]){
211+
$scope.$broadcast('ClearSelected');
212+
}
213+
213214
return;
214215
}
215216
if ($scope.cancelCallback){

0 commit comments

Comments
 (0)