Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by feature not by type: remove app/data/interface and app/data/enum #153

Open
skulptur opened this issue Jun 23, 2020 · 2 comments
Open

Comments

@skulptur
Copy link
Contributor

As the title says, I think those 2 directories can be gone. IAbstractComponentMixin should be moved to where it's used if really needed at all.

@ThaNarie
Copy link
Member

While I agree that it's good to move things where they belong as much as possible (like the IAbstractComponentMixin in this case), I find that there is still use to have project-wide folders for things that don't fit anywhere specifically.

We have the same issue with hooks and utils.

Although, having the folders there by default gives people an easy-way-out. So not having them forces them to think where to put something. Downside is that people will still add those generic folders, but name them differently between projects.

I think the smaller projects will use the global folders more often (since there is a less defined internal structure/separation, because of the initial overhead), and larger project that need more structure in general to organise the code, will have automatically have a place to put those files.

Happy to hear your opinions on the above, and your real-life experience :)

@ThijsTyZ
Copy link

I agree. We should not separate based on type.

And IAbstractComponentMixin is an interface for components, so it should move to the component directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants