Welcome to eslint-config Discussions, Read this first! #208
ThaNarie
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
👋 Welcome!
We’re using Discussions as a place to give feedback on certain ESLint rules, with the main goal of determining if a rule should be enabled, or how it should be configured.
It's important to understand how the current rules are set, or how we add new rules.
We follow most of the recommended presets, and tailor those to our existing coding style (driven by prettier), and the conventions we feel important to have in place.
Whenever new rules come out, if they are not immediately red flags, and we're not 100% sure if they will be helpful or annoying, we will include them. We do this to test them out, and gather feedback from others. If we wouldn't do this, not many rules would make it in, since the initial pushback is often worse when people are unfamiliar with things, or don't understand the exact purpose.
In general:
We try to measure the following things
1. In terms of code security/quality/maintainability – what does the rule prevent, and how bad is it when "invalid" code remains.
2. In terms of time wasted in Code Reviews and similar discussions
1. Is it auto-fixable? If so, it's almost always a no-brainer. Although there are situations where the created code is not always better (e.g. forEach > for-of)
2. Does it increase consistency? If so, bug plus.
3. What are the negative side-effects when the code follows the rule
4. How often would one disable the rule, and how valid are those cases? If only a small amount, it's still net benefit. I
If you have feedback
You might not agree with every rule, that's expected, since a lot is based on opinions, and people differ, it's impossible to satisfy everyone.
Before you start complaining to everyone and disabling the rule in all your projects, please do these things first:
If you still feel that the rule doesn't belong, please create a detailed Discussion or Issue with:
Then we can gather feedback from others, and if we agree in a semi-democratic way, we can change things.
To change things, we have a few options:
Beta Was this translation helpful? Give feedback.
All reactions