Skip to content

Commit 7120d13

Browse files
committed
add support for local logos; remove remote logos
1 parent 8d50f64 commit 7120d13

File tree

5 files changed

+32
-5
lines changed

5 files changed

+32
-5
lines changed

src/preview/dist/js/index_bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/preview/src/components/Previews.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,10 @@ export default function Previews({ data }) {
205205
<Box className="logos" display="flex" gap="0px" alignItems="center">
206206
<img src="Monks-Logo_Small_White.png" />
207207
{
208-
(pageAds.length > 0 && pageAds[0].client) &&
208+
data.client &&
209209
<Box display="flex" gap="10px" alignItems="center" sx={{marginRight: "10px"}}>
210210
<span>&times;</span>
211-
<img src={pageAds[0].client} />
211+
<img src={data.client} />
212212
</Box>
213213
}
214214
</Box>

src/webpack/buildPreview.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,13 @@ module.exports = async function buildPreview(result, qualities, outputDir) {
124124
))
125125
.filter(ad => ad != undefined)
126126

127+
const client = result[Object.keys(result)[0]]?.settings.data.settings.client
128+
127129
const adsList = {
128130
timestamp: Date.now(),
131+
client: client
132+
? `client.${client.split('.').at(-1)}`
133+
: undefined,
129134
ads: allAds
130135
};
131136

@@ -136,6 +141,14 @@ module.exports = async function buildPreview(result, qualities, outputDir) {
136141
await fs.copy(path.join(__dirname, `../preview/dist`), outputDir, {
137142
overwrite: true,
138143
});
144+
145+
// copy client logo
146+
if (client) {
147+
console.log("copying client logo...");
148+
await fs.copy(client, path.join(outputDir, `client.${client.split('.').at(-1)}`), {
149+
overwrite: true,
150+
});
151+
}
139152

140153
// write the result to ads.json in the preview dir
141154
console.log(`creating ${outputDir}/data/ads.json`)

src/webpack/devServer.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,17 @@ ${chalk.grey.bold('-------------------------------------------------------')}
8484

8585
openLocation && open(`${httpLocation}?gsdevtools=true`);
8686

87+
const client = configs[0].settings.data.settings.client
88+
if (client) {
89+
app.get(`/client.${client.split('.').at(-1)}`, (req, res) => {
90+
res.sendFile(configs[0].settings.data.settings.client)
91+
})
92+
}
93+
8794
app.get('/data/ads.json', (req, res) => {
8895
res.json({
8996
isGoogleSpreadsheetBanner: typeof configs[0].settings.data.settings.contentSource !== 'undefined',
97+
client: client ? `client.${client.split('.').at(-1)}` : undefined,
9098
ads: settingsList.map(e => {
9199
const assetName = getNameFromLocation(e.location)
92100
const bundleName = e.data.settings.bundleName || getNameFromLocation(e.location)
@@ -101,7 +109,6 @@ ${chalk.grey.bold('-------------------------------------------------------')}
101109
},
102110
},
103111
info: e.data.settings.info,
104-
client: e.data.settings.client,
105112
}
106113
})
107114
})

src/webpack/devServerParallel.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,17 @@ ${chalk.grey.bold('-------------------------------------------------------')}
9898

9999
openLocation && open(httpLocation);
100100

101+
const client = configs[0].settings.data.settings.client
102+
if (client) {
103+
app.get(`/client.${client.split('.').at(-1)}`, (req, res) => {
104+
res.sendFile(configs[0].settings.data.settings.client)
105+
})
106+
}
107+
101108
app.get('/data/ads.json', (req, res) => {
102109
res.json({
103110
isGoogleSpreadsheetBanner: typeof configs[0].settings.data.settings.contentSource !== 'undefined',
111+
client: client ? `client.${client.split('.').at(-1)}` : undefined,
104112
ads: settingsList.map(e => {
105113
const assetName = getNameFromLocation(e.location)
106114
const bundleName = e.data.settings.bundleName || getNameFromLocation(e.location)
@@ -115,7 +123,6 @@ ${chalk.grey.bold('-------------------------------------------------------')}
115123
},
116124
},
117125
info: e.data.settings.info,
118-
client: e.data.settings.client,
119126
}
120127
})
121128
})

0 commit comments

Comments
 (0)