Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False-positive in OPM_OVERLY_PERMISSIVE_METHOD for equals #468

Open
Vampire opened this issue Feb 29, 2024 · 1 comment
Open

False-positive in OPM_OVERLY_PERMISSIVE_METHOD for equals #468

Vampire opened this issue Feb 29, 2024 · 1 comment
Labels
needs investigation

Comments

@Vampire
Copy link

Vampire commented Feb 29, 2024

OPM_OVERLY_PERMISSIVE_METHOD in SpotBugs 3.1.12 just told me I should make equals protected, which of course would be invalid.
The class is package-private which triggers the bug I think.

Originally reported at spotbugs/spotbugs#1055
@Vampire Vampire mentioned this issue Feb 29, 2024
Closed
mebigfatguy added a commit that referenced this issue May 1, 2024
@mebigfatguy
add testcase for #468
bf816f7
@tautologicc
Copy link

The same false-positive happens with record accessors in Java 21: the plugin asks me to reduce their visibility, even though component accessors are required to be public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mebigfatguy @Vampire @tautologicc