From ee3b5937cf6f793e0fa992b9f9dea88cc89e63be Mon Sep 17 00:00:00 2001 From: JounQin Date: Sun, 14 Jan 2024 13:26:33 +0800 Subject: [PATCH] fix: `position` could be `null` actually (#524) --- .changeset/two-eagles-flash.md | 5 +++++ packages/eslint-plugin-mdx/src/rules/remark.ts | 8 +++++--- 2 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 .changeset/two-eagles-flash.md diff --git a/.changeset/two-eagles-flash.md b/.changeset/two-eagles-flash.md new file mode 100644 index 00000000..ce377820 --- /dev/null +++ b/.changeset/two-eagles-flash.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-mdx": patch +--- + +fix: `position` could be `null` actually - related to #520 diff --git a/packages/eslint-plugin-mdx/src/rules/remark.ts b/packages/eslint-plugin-mdx/src/rules/remark.ts index e7ced781..95b7385e 100644 --- a/packages/eslint-plugin-mdx/src/rules/remark.ts +++ b/packages/eslint-plugin-mdx/src/rules/remark.ts @@ -72,7 +72,7 @@ export const remark: Rule.RuleModule = { fatal, line, column, - position: { start, end }, + position, } of messages) { // https://github.com/remarkjs/remark-lint/issues/65#issuecomment-220800231 /* istanbul ignore next */ @@ -83,6 +83,8 @@ export const remark: Rule.RuleModule = { continue } + const { start, end } = position || /* istanbul ignore next */ {} + const message: RemarkLintMessage = { reason, source, @@ -96,11 +98,11 @@ export const remark: Rule.RuleModule = { line, // ! eslint ast column is 0-indexed, but unified is 1-indexed column: column - 1, - start: { + start: start && { ...start, column: start.column - 1, }, - end: { + end: end && { ...end, column: end.column - 1, },