Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fetching the largest version instead of just the latest version #39

Open
decoded4620 opened this issue Jun 9, 2024 · 1 comment

Comments

@decoded4620
Copy link

decoded4620 commented Jun 9, 2024

Sometimes - we have to go back to a previous major version and patch it. This becomes the latest 'tag'. When executed in CI/CD this causes an issue since the calculated new version will likely exist in tags - making it incorrect and likely to fail the tagging process.

.e.g tags in date order are:

v6.8.0
v3.2.8  # historical version with a patch fix gets inserted at the end

then

git commit -m "[minor] stuff"

will attempt to tag v2.9.0 - which already exists in our tags.

Suggestion:

git-semver -sort-on version -target minor

properly calculates the tag

v6.9.0

This enables recent patches to continue as planned without affecting the ongoing tagging process. Since the tagging code is encapsulted in this module - there is no reasonable amount of complexity we can add to get around it.

@SamSpiri
Copy link

Thanks for pointing this out. Saved a day, will search for alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants