Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask-position Initial value #713

Closed
kimgaeun77 opened this issue Feb 5, 2024 · 6 comments
Closed

mask-position Initial value #713

kimgaeun77 opened this issue Feb 5, 2024 · 6 comments
Assignees

Comments

@kimgaeun77
Copy link
Contributor

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

The page says that the mask-position Initial value is center, but when I tested it in Chrome, Firefox, etc., it was not center.

What did you expect to see?

I expected mask-position center as shown on the page.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@kimgaeun77 kimgaeun77 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 5, 2024
@bsmth bsmth removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 14, 2024
@bsmth
Copy link
Member

bsmth commented Feb 14, 2024

Thanks a lot @kimgaeun77 for raising this one. I dug a little into this and indeed, the initial value is 0% 0% (top-left corner). This is defined here:

data/css/properties.json

Lines 6868 to 6883 in af8a84a

"mask-position": {
"syntax": "<position>#",
"media": "visual",
"inherited": false,
"animationType": "repeatableList",
"percentages": "referToSizeOfMaskPaintingArea",
"groups": [
"CSS Masking"
],
"initial": "center",
"appliesto": "allElementsSVGContainerElements",
"computed": "consistsOfTwoKeywordsForOriginAndOffsets",
"order": "perGrammar",
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/mask-position"
},

I will move this into the data repo so we can fix it there.

@bsmth bsmth transferred this issue from mdn/content Feb 14, 2024
Copy link
Contributor

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@bsmth bsmth self-assigned this Feb 14, 2024
bsmth pushed a commit that referenced this issue Feb 22, 2024
…l value (#714)

…l value

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

The page says that the mask-position Initial value is center, but when I
tested it in Chrome, Firefox, etc., it was not center.
So I changed the initial value of the mask-position property from center
to 0% 0%.

### Motivation

It will be helpful for people working with CSS by referring to the mdn
document.

### Additional details

#713
https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
@bsmth
Copy link
Member

bsmth commented Feb 22, 2024

This is now fixed in the linked PR. Thanks a lot for raising and fixing 👍🏻

@bsmth bsmth closed this as completed Feb 22, 2024
@kimgaeun77
Copy link
Contributor Author

Yes, thank you too😊I have one question.
It doesn't seem to have changed in the mdn official document(https://developer.mozilla.org/en-US/docs/Web/CSS/mask-position) yet. Can you tell when it will change?

@bsmth
Copy link
Member

bsmth commented Feb 23, 2024

I have one question.

Sure thing: your changes have been included in #715. This new version will be picked up automatically as a bumped dependency in Yari -> https://github.com/mdn/yari/blob/main/CHANGELOG.md and it should be visible when builds are done with this new version. It may take a few days, but there's no other manual tasks outstanding, as far as I know.

@kimgaeun77
Copy link
Contributor Author

Thank you so much for letting me know😊Have a nice day!!👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants