-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
% unit is missing #553
Comments
We can add it, but which categories should we put it in?
Any more? |
A percent sign ( Btw, percentage is not limited to a length but can be used for any quantity, the spec defines the following productions:
And in |
This is getting even more confusing since houdini api calls it a percent and calls it a unit value
|
We don't call a % a "unit" largely for historical reasons, but it effectively is. The Typed OM API does call it one for simplicity; otherwise I'd need to invent a new class for it that is otherwise exactly identical to the one for unit values. Note that Typed OM also calls "number" a unit, for the same reason, even tho plain numbers are definitely distinct from unit values. All of this is to say, whether you categorize % as a "unit" or not is largely a matter of what makes the must sense for your particular case. That's no hard and fast answer. |
I am a bit surprised % is not in the units json, maybe I am not aware of some differentiation? Feel free to close if that's the case
The text was updated successfully, but these errors were encountered: