From 8858ac63fca5127b9137413338a852f2b251cf50 Mon Sep 17 00:00:00 2001
From: Frank Dana <ferdnyc@gmail.com>
Date: Sat, 20 Jan 2024 17:52:32 -0500
Subject: [PATCH] fix(css): Remove ::first-line from margin* props (#706)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

<!-- Commits need to adhere to conventional commits and only `fix:` and
`feat:` commits are added to the release notes. -->
<!-- https://www.conventionalcommits.org/en/v1.0.0/#examples -->

### Description

Correct the `alsoAppliesTo` for the CSS `margin` and
`margin-{top,bottom,left,right.trim}` properties.

### Motivation

The data claims that `margin*` properties apply to the `::first-line`
pseudoelement, which is untrue. They apply to `::first-letter`, but not
`::first-line`. As reported by @Akindin in mdn/content#31806.

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

Fixes mdn/content#31806
---
 css/properties.json | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/css/properties.json b/css/properties.json
index 6648662f..7e0c4bb6 100644
--- a/css/properties.json
+++ b/css/properties.json
@@ -6384,8 +6384,7 @@
     ],
     "order": "uniqueOrder",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "standard",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin"
@@ -6458,8 +6457,7 @@
     "computed": "percentageAsSpecifiedOrAbsoluteLength",
     "order": "uniqueOrder",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "standard",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-bottom"
@@ -6532,8 +6530,7 @@
     "computed": "percentageAsSpecifiedOrAbsoluteLength",
     "order": "uniqueOrder",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "standard",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-left"
@@ -6552,8 +6549,7 @@
     "computed": "percentageAsSpecifiedOrAbsoluteLength",
     "order": "uniqueOrder",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "standard",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-right"
@@ -6572,8 +6568,7 @@
     "computed": "percentageAsSpecifiedOrAbsoluteLength",
     "order": "uniqueOrder",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "standard",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-top"
@@ -6592,8 +6587,7 @@
     "computed": "asSpecified",
     "order": "perGrammar",
     "alsoAppliesTo": [
-      "::first-letter",
-      "::first-line"
+      "::first-letter"
     ],
     "status": "experimental",
     "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/margin-trim"