Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content bug: Description of focus events matches current spec but not reality #14084

Closed
danburzo opened this issue Mar 20, 2022 · 5 comments · Fixed by #14127
Closed

Content bug: Description of focus events matches current spec but not reality #14084

danburzo opened this issue Mar 20, 2022 · 5 comments · Fixed by #14127
Labels
Content:WebAPI Web API docs

Comments

@danburzo
Copy link
Contributor

What page(s) did you find the problem on?

What is the problem?

The pages match the text of the current spec, but browsers uniformly implement a different story, and it looks like the spec is due for an update to match the implementations.

What did you expect to see?

Should we be proactive and update the descriptions to match the soon-to-be-updated spec / current browser implementations?

@danburzo danburzo added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 20, 2022
@sideshowbarker
Copy link
Collaborator

Should we be proactive and update the descriptions to match the soon-to-be-updated spec / current browser implementations?

Yes, it seems like we should. Would you be willing to put together a pull request?

I think what the pull request would need to do is to change the text to say “Here’s what the spec says that browsers must do…” (which is what we have in the existing text) “…but here’s what browsers actually do instead…”

@sideshowbarker sideshowbarker added Content:WebAPI Web API docs and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 21, 2022
@danburzo
Copy link
Contributor Author

danburzo commented Mar 21, 2022

Yep, definitely. I wonder if we can't just skip the here's what the spec says part if the change in spec to match browser implementation is imminent — @garykac, could you give us an insight on this? — but I can also just rewrite based on current spec, and update the description once it changes.

@danburzo
Copy link
Contributor Author

See also the issues about adding the focus events to the HTML spec:

@sideshowbarker given the fact that the specs are still in flux, your call to add the note about current spec vs. browsers sounds like the right way to go.

@sideshowbarker
Copy link
Collaborator

Yep, definitely. I wonder if we can't just skip the here's what the spec says part if the change in spec to match browser implementation is imminent

Alternatively, we could wait to merge the PR until after the spec change is made.

But I note that review of the spec PR was requested more than 3 months ago but apparently hasn’t happened yet — so I’m not sure it’d be prudent for us to assume the spec change is imminent. Seems like we should wait to hear from @garykac.

@sideshowbarker
Copy link
Collaborator

@sideshowbarker given the fact that the specs are still in flux, your call to add the note about current spec vs. browsers sounds like the right way to go.

OK (though I guess it’s still possible the spec change might get merged before we end up getting our PR merged here)

@danburzo danburzo mentioned this issue Mar 21, 2022
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants