-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Firefox 146 supports compressed ECC key point format #28497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1158,6 +1158,44 @@ | |
| "deprecated": false | ||
| } | ||
| }, | ||
| "compressed_elliptic_curve_points": { | ||
| "__compat": { | ||
| "description": "ECDSA or ECDH key data can contain compressed elliptic curve points.", | ||
| "spec_url": "https://w3c.github.io/webcrypto/#ecdsa-operations-import-key", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "≤80" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 80 is the earliest version of chrome the the test I am using works for https://wpt.live/WebCryptoAPI/import_export/ec_importKey.https.any.html |
||
| }, | ||
| "chrome_android": "mirror", | ||
| "deno": { | ||
| "version_added": false | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't find information on node or deno so have set as false. |
||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "146" | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "nodejs": { | ||
| "version_added": false | ||
| }, | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ran on latest safari 26 https://wpt.live/WebCryptoAPI/import_export/ec_importKey.https.any.html - the particular tests show up as optional and fail. |
||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": "mirror", | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To set
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, done in a380a85 |
||
| "deprecated": false | ||
| } | ||
| } | ||
| }, | ||
| "ed25519": { | ||
| "__compat": { | ||
| "description": "`Ed25519` algorithm", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to respond to the spec question below, but I'm -0 on adding this subfeature. Speaking as a consumer of BCD (i.e., for web-features), this makes the data even harder to work with and, as written, is not something we can use to generate a status in web-features.
In a better world, this data would be represented as
api.SubtleCrypto.importKey.ecdsa.compressed_elliptic_curve_pointsandapi.SubtleCrypto.importKey.ecdh.compressed_elliptic_curve_points. But we don't have keys forecdsaandecdh, we just have notes inimportKeyfeature. This makes the problem worse by creating a named subfeature to notes of the parent feature, not the parent feature itself.I won't block on merging this—I do not have the time this month to do a rounds of follow up and re-review—but I think the addition of this subfeature makes the problem described in #27669 worse and I would like you to reconsider.