Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groupname update #543

Open
koenraad26 opened this issue Mar 20, 2023 · 10 comments
Open

groupname update #543

koenraad26 opened this issue Mar 20, 2023 · 10 comments

Comments

@koenraad26
Copy link

I've updated the groupname element
groupname.zip

@mdjnelson
Copy link
Owner

mdjnelson commented Jun 1, 2023

Can you please create a merge request instead of providing a zip? That way you will get the credit you deserve in the git history. :) Thanks.

@koenraad26
Copy link
Author

koenraad26 commented Jun 1, 2023 via email

@mdjnelson
Copy link
Owner

Well, Github is just using Git, so if you know Git I can help you create a MR if you would like. Otherwise, I can just look at the code in the zip and include if it is appropriate. Is it a separate element?

@koenraad26
Copy link
Author

koenraad26 commented Jun 5, 2023 via email

@mdjnelson
Copy link
Owner

Can you please tell me what this update is about and why it is being made?

@koenraad26
Copy link
Author

Hello Mark,

a customer of my wants the groupnames of student on the certificate.
You can now add groupname as element.

@mdjnelson
Copy link
Owner

What name and email would you like to be assigned to the commit? I am not looking at this now but will do in the future if I get time and can do the git work for you if you really don't want to.

@koenraad26
Copy link
Author

koenraad26 commented Jan 25, 2024 via email

@mdjnelson
Copy link
Owner

Ahh congratulations @koenraad26, useful skill to know. :) Soon you can fix all the bugs in this plugin and take over from me! :D

@mdjnelson
Copy link
Owner

Ping @koenraad26 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants