Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bfix: delay in search #30

Closed
wants to merge 2 commits into from
Closed

bfix: delay in search #30

wants to merge 2 commits into from

Conversation

anshikamittal25
Copy link
Collaborator

fixes #19

@guptaprakhariitr
Copy link
Member

guptaprakhariitr commented Apr 4, 2021 •
edited
Loading

  1. Please upload a gif showing the desired result.
  2. And specify how you fixed the problem. Just a basic approach idea.

@anshikamittal25
Copy link
Collaborator Author

anshikamittal25 commented Apr 4, 2021 •
edited
Loading

  1. Please upload a gif showing the desired result.
  2. And specify how you fixed the problem. Just a basic approach idea.

i simply moved the code for loading data to a separate file so that even when the user clicks on search function to switch to search screen before complete data loading, data loading doesn't stop and complete data is fetched

video.mp4

@guptaprakhariitr
Copy link
Member

@anshikamittal25 There are some issues with the screens:
Search "sunil" for example and try open each entry. You'll find error pops up in 2nd and 3rd entry. Please try rectify the error.

@guptaprakhariitr
Copy link
Member

Also can you show some text like, "No user found" if no entry maches search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delay in search
2 participants
@anshikamittal25 @guptaprakhariitr