Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changes flutter version #288

Merged
merged 1 commit into from
Oct 9, 2024
+13 −13
Merged

chore: changes flutter version #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: subosito/flutter-action@v2
with:
channel: "stable"
flutter-version: 3.19.0
flutter-version: 3.24.x

# Get flutter dependencies.
- run: flutter pub get
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/coupons/components/coupon_banner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class CouponBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/feedback/components/feedback_banner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class FeedbackBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/feedback/feedback_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class FeedbackScreen extends StatelessWidget {
textColor: Colors.white,
backgroundColor: AppTheme.green,
fontSize: 12.toAutoScaledFont);
context.router.pop();
context.router.maybePop();
}
if (state.error) {
Fluttertoast.showToast(
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/hostel_change/components/hostel_change_banner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class HostelChangeBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: () => context.router.pop(),
onPressed: () => context.router.maybePop(),
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
4 changes: 2 additions & 2 deletions lib/presentation/login/components/oauth_webview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class OAuthWebScreen extends StatelessWidget {
onUpdateVisitedHistory: (_, uri, __) {
if (uri != null) {
if (uri.toString().contains('https://channeli.in/feed')) {
context.router.pop();
context.router.maybePop();
//TODO: show dialog box
// SnackBarUtils.showDark('Error', 'Permission Denied!');
}
Expand All @@ -49,7 +49,7 @@ class OAuthWebScreen extends StatelessWidget {
var params = url.split('?').last.split('&');
if (params.first.contains('code')) {
var code = params.first.split('=').last;
context.router.pop(code);
context.router.maybePop(code);
}

return NavigationActionPolicy.CANCEL;
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/notifications/components/notification_banner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class NotificationBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
4 changes: 2 additions & 2 deletions lib/presentation/profile/profile_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,13 @@ class ProfileScreen extends StatelessWidget {
ProfilePageBloc>()
.add(
const DeleteHostelChangeRequest());
ctx.router.pop();
ctx.router.maybePop();
},
child: const Text('Delete'),
),
TextButton(
onPressed: () =>
ctx.router.pop(),
ctx.router.maybePop(),
child: const Text('Cancel'),
)
],
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/reset_password/components/reset_password_banner.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class ResetPasswordBanner extends StatelessWidget {
child: Row(
children: [
IconButton(
onPressed: context.router.pop,
onPressed: context.router.maybePop,
icon: const Icon(
Icons.arrow_back,
color: Colors.white,
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/reset_password/reset_password_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class ResetPasswordScreen extends StatelessWidget {
content: Text('Password reset successfully!'),
backgroundColor: Colors.green,
));
context.router.pop();
context.router.maybePop();
}
},
builder: (context, state) {
Expand Down
2 changes: 1 addition & 1 deletion lib/presentation/week_menu/components/DayMenu/menu_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class CouponDialogBox extends StatelessWidget {
Align(
alignment: Alignment.topRight,
child: GestureDetector(
onTap: context.router.pop,
onTap: context.router.maybePop,
child: const Padding(
padding: EdgeInsets.all(2.0),
child: Icon(Icons.close),
Expand Down
Loading