Commit 0cbeee3
committed
examples/10-graphics: the offscreen example runs on all three platforms
macOS and Windows built it and did not run it, which is the shape the
cross-platform work exists to remove: the half of a lane written for a host is
the half that host never exercises. A build asserts that the shader compiler
this platform publishes works and that the Vulkan half links. It cannot assert
that the loader hands the program a device, and on macOS that is the
interesting half.
The example now declares a device for those two platforms as well --
`xim:moltenvk` under `cfg(macos)`, `xim:mesa-lavapipe` under `cfg(windows)` --
rather than leaving CI to install one. The omission was invisible while the
example was never run, because a program that does not run never asks the
loader for a device, and declaring it here is what makes the example complete
for anyone who checks it out rather than only for the runner that had an extra
command.
The two CI steps therefore install nothing. They locate the ICD the build
already provisioned and set `VK_DRIVER_FILES`, so a manifest that failed to
name the driver fails the step. An `xlings install` in the step would have made
it pass either way.
macOS and Windows assert different things, and the difference is the point.
lavapipe is a software rasteriser producing the same pixels by construction, so
the image cannot distinguish it and the device name is what does. MoltenVK is
the host's own GPU through Metal, so its name differs by runner; what
distinguishes reaching a device there is that a centre pixel was reported at
all, which a portability driver the loader declined to show would not produce.
This closes the dependency between the two halves of the portability change:
the package without the enumeration finds no device, and the enumeration
without the package has nothing to find.1 parent 235449a commit 0cbeee3
3 files changed
Lines changed: 110 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
364 | 412 | | |
365 | 413 | | |
366 | 414 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
459 | 498 | | |
460 | 499 | | |
461 | 500 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
47 | 70 | | |
48 | 71 | | |
49 | 72 | | |
| |||
0 commit comments