Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Open
ghost opened this issue Jul 13, 2020 · 3 comments
Open

Update README.md #1

ghost opened this issue Jul 13, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 13, 2020

The README.md is empty, and that's not good for newcomers because it's not obvious what's the service is all about.

Also, wouldn't it be nice to change a project a bit in order to show people how to structure their fastify apps (maybe add src directory or smth like this)? I hope you've got my point.

It would be great to hear your opinion on this

Refs: nodejs/examples#9

@mcollina
Copy link
Owner

This is not meant to be a good individual example, it's actually the result of a "live coding" talk. It's not really meant to be consumed as an entry point (at least for now). Here is the video: https://www.youtube.com/watch?v=-X84Cq-nsLw

Would you like to send a PR?

@joesepi
Copy link

joesepi commented Jul 14, 2020

@mcollina can you point to a good individual example or should this one be worked on to be an individual example?

I ask because of the issue in nodejs/examples (nodejs/examples#9) that you commented on and linked to this example.

I'm happy to help and PR some updates. Thanks.

@mcollina
Copy link
Owner

Whatever you like/prefer. I do not have time to work on this right now, and this is a good starting point.
I also don't see the need of a README, as the work for nodejs/examples#9 needs to live somewhere else.

This is an example of how I would structure a Fastify application (minus a database is missing).

Happy for others to work on top of this or not, I do not have time right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants