Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try catch around complete causing confusing errors #15

Open
kumikoda opened this issue May 20, 2013 · 1 comment
Open

try catch around complete causing confusing errors #15

kumikoda opened this issue May 20, 2013 · 1 comment

Comments

@kumikoda
Copy link

i originally posted this as an issue i thought your library had. But i quickly realized that this was an error in my own code.

The confusion stems from the try/catch in class.instagram.coffee at line 129. I think your try catch is intended for the JSON.parse() line but it covers the complete statement as well, causing it to catch any uncaught errors in the callback. Instead, would it better just to throw the otherwise uncaught exception?

@gabrielstuff
Copy link

agree , I fall in the same trap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants