Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider new name for DMatrix / Booster alias #46

Open
chester-leung opened this issue Apr 13, 2020 · 0 comments
Open

Consider new name for DMatrix / Booster alias #46

chester-leung opened this issue Apr 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@chester-leung
Copy link
Member

In #43 we introduced using an alias to identify DMatrix / Booster objects inside the enclave. We should rename the defined type given to this alias to not confuse those navigating the codebase. Currently, the defined types are DMatrixHandle / BoosterHandle, the same name as the originally used pointers.
@chester-leung chester-leung added the enhancement New feature or request label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chester-leung