Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different exposing rule for library projects #5

Open
mbuscemi opened this issue Dec 28, 2017 · 2 comments
Open

Different exposing rule for library projects #5

mbuscemi opened this issue Dec 28, 2017 · 2 comments
Assignees
Milestone

Comments

@mbuscemi
Copy link
Owner

Library projects expose functions without references for good reason. Elm Lens should be able to recognize exposed library methods and provide special markup rules for those.

Issue came to my attention from here: stil4m/elm-analyse#10

@mbuscemi mbuscemi self-assigned this Dec 28, 2017
@zwilias
Copy link
Collaborator

zwilias commented Dec 28, 2017

How does whitelisting exposed values from exposed modules sound? Applications shouldn't have exposed-modules, packages expose modules so that their exposed values can be imported externally, so I think that would be more or less accurate.

@mbuscemi
Copy link
Owner Author

Elm 0.19 will provide facilities in elm-package.json to differentiate library from application projects. However, I believe I can achieve this goal now.

In Elm 0.18, we already have the exposed-modules field in elm-package.json. The quickest fix would be to turn off the warning markers on zero-ref-external functions in exposed modules. Additionally, I think adding a world icon, or something iconographically similar, to all such functions would be a great additional touch.

@mbuscemi mbuscemi added this to the 0.4.0 milestone Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants